ENH/CLN: Add factorize to IndexOpsMixin #7090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this seems reasonable; factorize for a |
|
rebase 1 more time (I think just rlease notes conflict then good to go) |
17 tasks
jreback
added a commit
that referenced
this pull request
May 10, 2014
ENH/CLN: Add factorize to IndexOpsMixin
|
@sinhrks thanks! |
|
@jreback Thanks to merge. Added more tests and added descriptions to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed in #7041, I prepared a PR to add
factorizetoIndexOpsMixin.As a side benefit,
Multiindex.from_arrayscan preserve originalDatetimeIndex.freqandtz. (Related to #3950 and #6606. These issues are not solved yet because these use different methods to createMultiIndex).I would like to confirm following points before adding more tests.
Index.factorizeandSeries.factorizeshould return as unique values,ndarrayorIndex? I think it should returnIndexto preserveDatetimeIndexattributes (freqandtz).api.rst?